Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on tokio_unstable config flag #62

Open
wants to merge 1 commit into
base: movement
Choose a base branch
from

Conversation

mzabaluev
Copy link
Collaborator

Description

Tokio does not guarantee semver stability of unstable features, so it's a bad idea to use this flag. It's also annoying to have to override rustflags everywhere.
Remove the tokio_unstable flag from local cargo config and change the affected code to not use unstable features.

Type of Change

  • Refactoring

Which Components or Systems Does This Change Impact?

  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure

How Has This Been Tested?

cargo check -p movement should build, while .cargo/config.toml has been modified to not pass --cfg tokio_unstable to rustc.

Key Areas to Review

Whether the changes in runtime behavior could be harmful. I don't think so, it's a perf tweak and before we have proof this degrades performance, I think all such tweaks are fair game to remove.

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Tokio does not guarantee semver stability of unstable features,
so it's a bad idea to use this flag. It's also annoying to have to
override rustflags everywhere.
@mzabaluev mzabaluev requested a review from 0xmovses August 28, 2024 15:41
@mzabaluev mzabaluev changed the title Don't rely on tokio_unstable config flag Don't rely on tokio_unstable config flag Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant