Don't rely on tokio_unstable
config flag
#62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tokio does not guarantee semver stability of unstable features, so it's a bad idea to use this flag. It's also annoying to have to override rustflags everywhere.
Remove the
tokio_unstable
flag from local cargo config and change the affected code to not use unstable features.Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
cargo check -p movement
should build, while.cargo/config.toml
has been modified to not pass--cfg tokio_unstable
to rustc.Key Areas to Review
Whether the changes in runtime behavior could be harmful. I don't think so, it's a perf tweak and before we have proof this degrades performance, I think all such tweaks are fair game to remove.
Checklist