Skip to content
This repository has been archived by the owner on Dec 6, 2019. It is now read-only.

Deal with rendering issues #13

Closed
antoniocapelo opened this issue Nov 13, 2017 · 1 comment
Closed

Deal with rendering issues #13

antoniocapelo opened this issue Nov 13, 2017 · 1 comment
Labels
bug

Comments

@antoniocapelo
Copy link
Contributor

From @satazor on February 19, 2017 12:40

At the moment, if render or similar functions throw an error the following happens:

  • On the server-side, the internal-error is rendered, which is ok!
  • On the client-side, all falls apart with a blank page.

See: facebook/react#2461

Copied from original issue: #20
@satazor
Copy link
Contributor

satazor commented Nov 20, 2017

Now that #30 added react v16 we now have componentDidCatch. We should now re-evaluate this.

andregoncalvesdev added a commit that referenced this issue Feb 25, 2018
@andregoncalvesdev
fix: handle internal server error on client
9032c03 
Closes #13
@andregoncalvesdev andregoncalvesdev mentioned this issue Feb 25, 2018
Merged
andregoncalvesdev added a commit that referenced this issue Feb 25, 2018
@andregoncalvesdev
fix: handle internal server error on client
334d73e 
Closes #13
andregoncalvesdev added a commit that referenced this issue Feb 25, 2018
@andregoncalvesdev
fix: handle internal server error on client
8c16c38 
Closes #13
satazor pushed a commit that referenced this issue Feb 25, 2018
@andregoncalvesdev @satazor
fix: handle internal server error on client (#62)
94129e8 
Closes #13
@antoniocapelo antoniocapelo mentioned this issue Apr 28, 2018
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@satazor @antoniocapelo