Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch checks that all the features of a record are distinct.
For the following example
we get (separately)
I am still unhappy with the reordering that occurs in the error messages. I think th "Feature-field Pairs" should be printed in the order they were passed to Boot_record.makeDynamic, not the order resulting from the unstable std::sort.
With the first error, the static analyser catches the kernel error and prints the list of features in the correct order. Mozart1 used to return the unsorted features in all the cases.
That being said, I think this error code could be redesigned from scratch, and that the order of the features in the specific case of duplicate features is not really relevant. This is why I suggest to merge this patch.
@sjrd As usual, comments on C++ style are more than welcome.
Fixes #285