Integrate the OPI #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This compilation and execution can be run through
view.run_command("oz_run") in Sublime Text Shell
This commit does not allow to retrieve correctly the socket number from the output. Indeed, it contains undefined behavior.
This commit merges the two created thread. It removes many unused features from socket_pipe. It also uses the module select to poll both the outputs from ozengine and those from the socket.
Clear panels on restart
|
@layus @azarzadavila Thanks, this is a big contribution! I was meaning to get build/run support added. After I merge this, I'll tag another release. And yes, we can move this to the mozart org. I will have to open a PR against package_control_channel to update packagecontrol.io once we do. |
|
@rkoeninger Thanks ! I have invited you to the mozart organisation. After that you can move the repository on your own. That way you keep full control over the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rkoeninger,
This PR is a huge feature that was developed at UCLouvain (where
mozart/oz is maintained) by @azarzadavila durung an internship.
We would really love to see this merged as it provides tons of
convenience to novice users.
Also, would you consider moving your repo to the https://github.com/mozart project ?
You would keep management rights on it and gain a bit more visibility.