Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

check state properly when foregrounding / backgrounding #1023

Merged
merged 1 commit into from
May 29, 2019
Merged

check state properly when foregrounding / backgrounding #1023

merged 1 commit into from
May 29, 2019

Conversation

sashei
Copy link
Contributor

@sashei sashei commented May 28, 2019 •
edited by devinreams
Loading

Fixes #1022

Testing and Review Notes

The bug description is good for reproducing this issue.

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • make sure CI builds are passing (e.g.: fix lint and other errors)

@sashei sashei requested a review from a team as a code owner May 28, 2019 20:55
devinreams
devinreams approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@devinreams devinreams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fixed (after background then reopening, the app is locked) on iPhone XS with build 3417:

  • after manually locking from settings
  • after timed auto lock elapsed

@sashei sashei merged commit e960422 into master May 29, 2019
@sashei sashei deleted the 1022-foreground-background-correctly branch May 29, 2019 14:49
@devinreams devinreams mentioned this pull request May 29, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devinreams devinreams devinreams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Putting the locked app in background and then in foreground unlocks the app
2 participants
@sashei @devinreams