Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Increase cancel button width in AutoFill list view #1048

Merged
merged 2 commits into from
Jun 11, 2019

Conversation

devinreams
Copy link
Contributor

Closes #1047

Testing and Review Notes

  • change device language to Spanish or German
  • enable AutoFill in system settings
  • open a website with a user/pass and press the "Key" 🔑 icon to open AutoFill list view
  • observe the cancel button in the top left of navigation

Expected and Actual: "Cancelar" and "Abbrechen" should fit without elipses truncating it in the middle like "Can..ar"

Screenshots or Videos

FR:

image

ES (after):

Screen Shot 2019-06-07 at 9 35 42 AM

DE (after and to see how "crowded" with the large-to-small title moving into nav bar):

Screen Shot 2019-06-07 at 9 41 34 AM

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • add unit tests
    • optional: consider adding integration tests (UI specs)
  • consider running this branch in the simulator and check for warnings
  • request the "UX" team perform a design review (if/when applicable)
  • make sure CI builds are passing (e.g.: fix lint and other errors)

@devinreams devinreams requested a review from a team as a code owner June 7, 2019 15:44
Copy link
Contributor

@sashei sashei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢

@devinreams devinreams merged commit e9687c7 into master Jun 11, 2019
@devinreams devinreams deleted the 1047-cancel-width branch June 11, 2019 16:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

l10n: AutoFill Cancel button appears with ellipsis in the middle
2 participants