Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Update localization strings #1160

Merged
merged 4 commits into from
Jan 8, 2020
Merged

Update localization strings #1160

merged 4 commits into from
Jan 8, 2020

Conversation

kaylagalway
Copy link
Contributor

@kaylagalway kaylagalway commented Dec 11, 2019 •
edited
Loading

Pulls in new Localization strings

@kaylagalway kaylagalway requested a review from a team as a code owner December 11, 2019 21:47
@kaylagalway
Copy link
Contributor Author

kaylagalway commented Dec 11, 2019 •
edited
Loading

This build is currently failing because of the following error: error: Build input file cannot be found: '/Users/kaylagalway/dev/mozilla/lockwise-ios/lockbox-ios/Storyboard/es.lproj/NoNetwork.strings' (in target 'Firefox Lockbox' from project 'Lockbox')

Working on resolving this.

Created ticket #1177

@kaylagalway kaylagalway changed the title Update localization strings for version 1.7.1 Update localization strings Dec 11, 2019
eliserichards
eliserichards approved these changes Jan 7, 2020
View reviewed changes
Copy link

@eliserichards eliserichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaylagalway kaylagalway merged commit 368f4ca into master Jan 8, 2020
@kaylagalway kaylagalway added this to the 1.7.2 milestone Jan 8, 2020
@kaylagalway kaylagalway mentioned this pull request Feb 7, 2020
Closed
@kaylagalway kaylagalway deleted the localization-1.7.1 branch February 12, 2020 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eliserichards eliserichards eliserichards approved these changes

@jhugman jhugman Awaiting requested review from jhugman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@kaylagalway @eliserichards