This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
toggle password to hidden on backgrounding #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
previously requested changes
May 21, 2019
jhugman
approved these changes
May 21, 2019
| .disposed(by: self.disposeBag) | ||
|
|
||
| self.routeStore.onRoute | ||
| .filterByType(class: MainRouteAction.self) |
There was a problem hiding this comment.
Nit: Aren't all Actions that come out of the RouteStore MainRouteActions?
There was a problem hiding this comment.
No, we separated the RouteActions on iOS into LoginRouteActions, MainRouteAction etc.... :p
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #988
Testing and Review Notes
Testing by backgrounding + returning to the app should be sufficient here.
codereviewers: I did a light refactor to make the
ItemDetailStorecleaner here.To Do