Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

remove button to direct to settings when logging in #996

Merged
merged 1 commit into from
May 21, 2019
Merged

remove button to direct to settings when logging in #996

merged 1 commit into from
May 21, 2019

Conversation

sashei
Copy link
Contributor

@sashei sashei commented May 20, 2019 •
edited
Loading

Fixes #803

Testing and Review Notes

Just dropping a reminder that you cannot test device authentication work on a simulator!

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • add unit tests
  • make sure CI builds are passing (e.g.: fix lint and other errors)

@sashei sashei requested a review from a team as a code owner May 20, 2019 20:01
jhugman
jhugman approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sashei sashei merged commit 3500e2c into master May 21, 2019
@sashei sashei deleted the 803-remove-settings-route branch May 21, 2019 15:01
sashei added a commit that referenced this pull request May 21, 2019
@sashei
remove button to direct to settings when logging in (#996)
79f10a0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jhugman jhugman jhugman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS 12.x] "Set Passcode" button directs to wrong screen because Apple doesn't provide a way to link directly
2 participants
@sashei @jhugman