Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

System Download Notification #5959

Closed
10 tasks
vesta0 opened this issue Oct 11, 2019 · 9 comments
Closed
10 tasks

System Download Notification #5959

vesta0 opened this issue Oct 11, 2019 · 9 comments
Assignees
Labels
E13 Estimation Point: about 10 days eng:qa:verified QA Verified Feature:Download needs:strings Needs strings
Milestone

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Oct 11, 2019

User Story

As a user, I want to know the status of my download and have the ability to manage the download process so I can have control and visibility over my download activity.

Mocks
Deck

Acceptance Criteria

  • I see that my download is in progress
  • I can pause my download
  • I can resume my paused download
  • I can cancel my download
  • I know when my download is completed
  • I know when my download fails
  • I can try again on a failed download
  • The download completed notification includes a link to the downloaded file
  • I can tap on this link to open the file
  • I can manage multiple downloads simultaneously

┆Issue is synchronized with this Jira Task

@severinrudie
Copy link
Contributor

@sblatz do you know if the strings for this story have already been landed? If not, do you have a list of what needs to go in so I can get them in before string freeze?

@sblatz
Copy link
Contributor

sblatz commented Oct 30, 2019

The strings are all in Android Components.

sblatz added a commit to sblatz/fenix that referenced this issue Oct 31, 2019
@ekager ekager added the eng:qa:needed QA Needed label Oct 31, 2019
@ekager ekager removed the eng:qa:needed QA Needed label Oct 31, 2019
@sblatz sblatz added the eng:qa:needed QA Needed label Nov 1, 2019
@lobontiumira
Copy link

I've tested with today Nightly build from Play Store 11/4 (#13080608) with Google Pixel (Android Q), and Nokia 6 (Android 7.1.1), and these are the results:

  • the download progress is visible on Nokia 6, but not on Google Pixel:
    download-progress

  • I was able to pause my download on both devices;

  • I was NOT able to resume my paused download when I downloaded an .apk file and resumed it, the download failed - please see the attached logcat from the Nokia device:
    logcat.txt

  • I was able to cancel my download on both devices;

  • I know when that the download is completed, but I don't have the "Open" option:
    download completed

  • I know when my download fails;

  • I can try again on a failed download;

  • the completed downloads notifications does NOT include a link to the downloaded file;

  • I cannot tap on this link to open the file - there is no "Open" option in the notification;

  • I can manage multiple downloads simultaneously.

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Nov 4, 2019
@sblatz
Copy link
Contributor

sblatz commented Nov 4, 2019

@softvision-miralobontiu

Thanks for testing this. A couple things:

the completed downloads notifications does NOT include a link to the downloaded file;
I cannot tap on this link to open the file - there is no "Open" option in the notification;

We decided to forego the "open" button. I think @brampitoyo has just not updated the mocks to include this change. If you tap anywhere on the notification, it will open the file for you.

I was NOT able to resume my paused download when I downloaded an .apk file and resumed it, the download failed - please see the attached logcat from the Nokia device:

Is this device specific? Were you able to pause APK's on certain websites but not others?

@lobontiumira
Copy link

@sblatz I tried on Nokia 6 (Android 7.1.1), Motorola Moto G6 (Android 8), Huawei P9 Lite (Android 7), and Google Pixel (Android Q), and all gave the same result. After I resumed the .apk download, the download failed. After tapping on "Try again", the download restarted.

@sblatz
Copy link
Contributor

sblatz commented Nov 4, 2019

@softvision-miralobontiu Did this happen on multiple websites or just one? I am able to get this to work properly on Github, for example. I wonder if it's an issue with a specific website.

@sblatz
Copy link
Contributor

sblatz commented Nov 4, 2019

Essentially: we know that downloads will fail when trying to resume on some sites. This is expected behavior, and as long as the try again button works in those cases, this ticket is complete :)

@sblatz sblatz closed this as completed Nov 4, 2019
@brampitoyo
Copy link

@softvision-miralobontiu

@sblatz is totally right:

We decided to forego the "open" button. I think @brampitoyo has just not updated the mocks to include this change.

The mocks on the board has now been updated. Sorry about that.

@lobontiumira
Copy link

@sblatz I could reproduce only on downloading from the taskcluster page, the Reference-Browser apk.
Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E13 Estimation Point: about 10 days eng:qa:verified QA Verified Feature:Download needs:strings Needs strings
Projects
None yet
Development

No branches or pull requests

8 participants