Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-8698 Firefox Focus 124.0 crashes on startup on iOS #19297

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Bugfix FXIOS-8698 Firefox Focus 124.0 crashes on startup on iOS #19297

merged 1 commit into from
Mar 19, 2024

Conversation

razvanlitianu
Copy link
Collaborator

@razvanlitianu razvanlitianu commented Mar 19, 2024 •
edited
Loading

💡 Description

On the PR below some search engines were removed or updated. This PR fixes the crash by updating the list also on .plist.
dbbbf21

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@razvanlitianu razvanlitianu requested review from OrlaM and nbhasin2 March 19, 2024 16:02
@razvanlitianu razvanlitianu marked this pull request as ready for review March 19, 2024 16:02
@razvanlitianu razvanlitianu requested a review from a team as a code owner March 19, 2024 16:02
@OrlaM OrlaM added the Focus label Mar 19, 2024
@razvanlitianu razvanlitianu changed the title Remove from the plist of SearchEngine previously deleted files Bugfix FXIOS-8698 #19287 Firefox Focus 124.0 crashes on startup on iOS Mar 19, 2024
@razvanlitianu razvanlitianu changed the title Bugfix FXIOS-8698 #19287 Firefox Focus 124.0 crashes on startup on iOS Bugfix FXIOS-8698 Firefox Focus 124.0 crashes on startup on iOS Mar 19, 2024
@clarmso clarmso merged commit 8d95187 into mozilla-mobile:main Mar 19, 2024
7 checks passed
@dsmithpadilla
Copy link
Contributor

@mergify backport release/v124

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 19, 2024 •
edited
Loading

backport release/v124

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 19, 2024
@razvanlitianu @mergify
Remove from the plist of SearchEngine previously deleted files (#19297)
2d5cd54 
(cherry picked from commit 8d95187)
@mergify mergify bot mentioned this pull request Mar 19, 2024
Merged
6 tasks
dsmithpadilla pushed a commit that referenced this pull request Mar 19, 2024
@mergify @razvanlitianu
Remove from the plist of SearchEngine previously deleted files (#19297)…
cd23d3f 
… (#19299)

(cherry picked from commit 8d95187)

Co-authored-by: Litianu Razvan <litianu.razvan@gmail.com>
@dsmithpadilla
Copy link
Contributor

@mergify backport release/v125

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 19, 2024 •
edited
Loading

backport release/v125

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 19, 2024
@razvanlitianu @mergify
Remove from the plist of SearchEngine previously deleted files (#19297)
ae0e52f 
(cherry picked from commit 8d95187)
@mergify mergify bot mentioned this pull request Mar 19, 2024
Merged
6 tasks
OrlaM pushed a commit that referenced this pull request Mar 19, 2024
@mergify @razvanlitianu
Bugfix FXIOS-8698 Firefox Focus 124.0 crashes on startup on iOS (back…
7406290 
…port #19297) (#19300)

(cherry picked from commit 8d95187)

Co-authored-by: Litianu Razvan <litianu.razvan@gmail.com>
@razvanlitianu razvanlitianu deleted the rlitianu/focus-crash2 branch March 20, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrlaM OrlaM OrlaM approved these changes

@nbhasin2 nbhasin2 Awaiting requested review from nbhasin2

Assignees
No one assigned
Labels
Focus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@razvanlitianu @dsmithpadilla @OrlaM @clarmso