Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FXIOS-19318 - Update Fonts in SnackBar to use FXFontStyles #19324

Merged

Conversation

rojinpra7
Copy link
Contributor

@rojinpra7 rojinpra7 commented Mar 21, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

  • This PR updates the font styles used in SnackBar to use FXFontStyles to standardize the font.

Screenshots

Before After
Before After

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@rojinpra7 rojinpra7 requested a review from a team as a code owner March 21, 2024 06:11
@rojinpra7 rojinpra7 requested a review from dataports March 21, 2024 06:11
Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this change @rojinpra7! code looks good! The screenshots in the description seems to refer to our simpleToasts instead of the snack bar, but approving based on the code changes!

@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Mar 21, 2024

Messages
📖 Project coverage: 33.71%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 32.45

File Coverage
SnackBar.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 673abed

@rojinpra7
Copy link
Contributor Author

@cyndichin how do I recognize the UI of the code that I'm working with? Is there any documentation?

@cyndichin
Copy link
Contributor

@cyndichin how do I recognize the UI of the code that I'm working with? Is there any documentation?

Good question! We do have component library that we are slowly adding more UI components to. These components you can view with the SampleComponentLibrary project in the repo. More info here.

However in this case, which the UI has not been added to library yet, you can track down how this class is used in the codebase through search. For example, TimerSnackBar inherits SnackBar, which is used in LoginsHelper to trigger this UI.

Snack Bar
Simulator Screenshot - iPhone 15 Pro - 2024-03-21 at 13 40 56

@cyndichin cyndichin merged commit dfd36af into mozilla-mobile:main Mar 21, 2024
10 checks passed
@rojinpra7
Copy link
Contributor Author

@cyndichin Thank you. This was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants