Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-7871 [v125] Opening a link in external app leaves a "loading" about:blank page behind (backport #19288) #19339

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Bugfix FXIOS-7871 [v125] Opening a link in external app leaves a "loading" about:blank page behind (backport #19288) #19339

merged 1 commit into from
Mar 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 21, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

Verify if an app like Youtube is installed and open it when a link (e.g. Youtube link) is accessed.

Based on the issue description and comments, I added in the apps list (LSApplicationQueriesSchemes), Youtube, Instagram and PayPal.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #19288 done by [Mergify](https://mergify.com).

@dicarobinho @mergify
FXIOS-7871 #17571 ⁃ Opening a link in external app leaves a "loading"…
aa15686 
… about:blank page behind (#19288)

Co-authored-by: Alexandru Farcasanu <c_afarcasanu@groupon.com>
(cherry picked from commit 85cebaa)
@mergify mergify bot requested a review from a team as a code owner March 21, 2024 19:27
@mergify mergify bot requested review from nbhasin2 and removed request for a team March 21, 2024 19:27
@mergify mergify bot mentioned this pull request Mar 21, 2024
Merged
6 tasks
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.82%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 32.48

File Coverage
BrowserViewController+WebViewDelegates.swift 1.74% ⚠️

Generated by 🚫 Danger Swift against aa15686

@OrlaM OrlaM merged commit 7dd343a into release/v125 Mar 22, 2024
12 checks passed
@OrlaM OrlaM deleted the mergify/bp/release/v125/pr-19288 branch March 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbhasin2 nbhasin2 Awaiting requested review from nbhasin2 nbhasin2 is a code owner automatically assigned from mozilla-mobile/fxios-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mobiletest-ci-bot @OrlaM @dicarobinho