Chore: Fix signature crate build errors on Linux/arm64 #8339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gela
approved these changes
Oct 19, 2023
oskirby
added a commit
that referenced
this pull request
Oct 19, 2023
5 tasks
oskirby
added a commit
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new signature crate in Rust fails to build from source on Linux/arm64 due to mismatched char signedness. This isn't one of our supported targets, but the
ppa:okirby/mozilla-vpn-testingPPA makes an attempt to build them for completeness.The fix is to use
std::os::raw::c_charin place ofi8for string pointers.Reference
Build failures:
Checklist