Conda pack for iOS #8545
Merged
Conda pack for iOS #8545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strseb
force-pushed
the
basti/pack_conda_darwin
branch
from
2d8b033
to
bf427bc
Compare
strseb
force-pushed
the
basti/pack_conda_darwin
branch
from
abdf777
to
cc33e63
Compare
strseb
force-pushed
the
basti/pack_conda_darwin
branch
from
082147f
to
56842c8
Compare
strseb
force-pushed
the
basti/pack_conda_darwin
branch
from
56842c8
to
3e39bf4
Compare
brizental
approved these changes
Jan 23, 2024
| @@ -17,9 +17,9 @@ fi | |||
|
|
|||
| export QT_DIR=$CONDA_PREFIX/Qt | |||
| # QT_Host Tools | |||
| python -m aqt install-qt --outputdir $QT_DIR $HOST_TARGET | |||
| python -m aqt install-qt --outputdir $QT_DIR $HOST_TARGET -m all | |||
There was a problem hiding this comment.
Why was this change required now and not required before?
There was a problem hiding this comment.
It seems we have a new tool (for 6.6)) that the host is expected to have but that's not in the default install 😖
Comment on lines
+28
to
+42
| ios-arm64-qt-next/debug: | ||
| description: "IOS Debug Build using Qt-Next" | ||
| treeherder: | ||
| symbol: NEXT | ||
| fetches: | ||
| toolchain: | ||
| - conda-ios-6.6.0 | ||
|
|
||
| ios-arm64/debug: | ||
| description: "IOS Debug Build using Qt-Next" | ||
| treeherder: | ||
| symbol: BD | ||
| fetches: | ||
| toolchain: | ||
| - conda-ios-6.2.4 |
There was a problem hiding this comment.
For my understanding. This change is unrelated to the conda pack stuff, right?
There was a problem hiding this comment.
I guess it's made easier by the conda-pack stuff... 🤔
There was a problem hiding this comment.
I should have named the pr "let's build iOS with qt 6.6 and for that i am clearing some tech debt" :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Android & Windows we pre-pack the conda enviroment once if the env.yml changes.
iOS and Macos still fetch that every time on build, so let's start packing that too.