VPN-6375 - Fix QML modules import #9531
Conversation
There was a problem hiding this comment.
But I kinda hate the way it fixes it, makes no sense.
I may actually hate this less than the qmldir files which were (I think) facilitating this before. I think my only concern here is that there are related bugs waiting to be found. For instance we'll definitely need to add similar import statements to ViewServers.qml, ViewMultiHop.qml and maybe some of the in-app auth views as well.
Interesting. If this is the case, then we might have another easier and better fix. CMake is building the qmldir file for us now, it's not like they are gone. Maybe we just need to point the build to the right place where the file is now 🤔 |
Ok, so here is the thing: this fixes the issue and I don't know why. With the removal of qmldir files manually written by developers and the usage of qt_add_qml_module, it's not like there will not be any more qmldir files, it's that they will be generated for us. When I looked at the generated files I noted they have this in the header linktarget mozillavpn-uiplugin plugin mozillavpn-uiplugin classname Mozilla_VPNPlugin typeinfo mozillavpn-ui.qmltypes prefer :/Mozilla/VPN/ These are not defined in the lottie and nebula qmldir files -- which work. I started playing around with options that would change this such as NO_PLUGIN (which did nothing) and NO_PLUGIN_OPTINAL which fixed the import issues we were having :shrug.
| @@ -5,6 +5,7 @@ | |||
| qt_add_qml_module(mozillavpn-ui | |||
| VERSION 1.0 | |||
| URI Mozilla.VPN | |||
| NO_PLUGIN_OPTIONAL | |||
There was a problem hiding this comment.
Ok, so here is the thing: this fixes the issue and I don't know why.
With the removal of qmldir files manually written by developers
and the usage of qt_add_qml_module, it's not like there will not
be any more qmldir files, it's that they will be generated for us.
When I looked at the generated files I noted they have this in the header
linktarget mozillavpn-uiplugin
optional plugin mozillavpn-uiplugin
classname Mozilla_VPNPlugin
typeinfo mozillavpn-ui.qmltypes
prefer :/Mozilla/VPN/
These are not defined in the lottie and nebula qmldir files -- which work.
I started playing around with options that would change this such as
NO_PLUGIN (which did nothing) and NO_PLUGIN_OPTINAL which fixed the import
issues we were having :shrug.
There was a problem hiding this comment.
Oh yeah, just for the record. After I aded this property
this is what the header looks like:
linktarget mozillavpn-uiplugin
plugin mozillavpn-uiplugin
classname Mozilla_VPNPlugin
typeinfo mozillavpn-ui.qmltypes
prefer :/Mozilla/VPN/
brizental
changed the title
brizental
changed the title
Ok, something funky is happening with the Qt6.6 imports.
Here is the thing, this patch fixes it. But I kinda hate the way it fixes it, makes no sense.
Opening as a draft, as food for thought. It seems sometime Qt6.6 is unable to resolve QML files in the same module???? cc @lesleyjanenorton for QML knowledge.