Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in flatpak crate update script #9856

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Sep 9, 2024

Description

Looks like there was a bug in the script used to update flatpak package dependencies. Notably the argument count check is incorrect which causes the script to run exclusively by pulling cargo.lock from main. Unfortunately this breaks PRs which attempt to update the Cargo.lock file, such as our dependabot PRs.

The fix is simply to correct the conditional check, but we also add some logging to the script to be extra sure where it is fetching the Cargo.lock file from.

Reference

Introduced by: #9798

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby marked this pull request as ready for review September 9, 2024 22:12
@oskirby oskirby merged commit fad1e36 into main Sep 11, 2024
115 checks passed
@oskirby oskirby deleted the flatpak-crate-update-bug branch September 11, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants