Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taskcluster: remove flatpak build and toolchain tasks #9860

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Sep 11, 2024

Description

In the last update to flatpaks, we revised the build jobs in Github Workflows to make better use of the official Flatpak build tooling, and eliminated the need to manually vendor the rust crates by making use of the flatpak-cargo-generator.py script.

Once 2.24 is released, my plan is to attempt to create an official release on Flathub by migrating all of that work into the flathub organization so that they can begin generating and publishing official builds for us.

As such, we no longer really have a need to perform our own Flatpak builds using taskcluster as the release pipeline for the VPN on Flathub isn't going to touch any Mozilla infrastructure at all. Therefore, I think it is time that we remove the taskcluster flatpak build and toolchains tasks.

It is not without a little bit of sadness too, because I thought the podman-worker.py was a really neat piece of work to grant privileges to Docker containers that otherwise wouldn't have been possible via the Docker workers.

Reference

i.e Jira or Github issue URL

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby marked this pull request as ready for review September 11, 2024 15:59
@oskirby oskirby requested a review from a team as a code owner September 11, 2024 15:59
@oskirby oskirby requested review from jcristau, mcleinman and strseb and removed request for a team September 11, 2024 15:59
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫗 Pour one out for the podman worker.

Copy link
Collaborator

@strseb strseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@oskirby oskirby enabled auto-merge (squash) September 11, 2024 17:59
@github-actions github-actions bot added the 🛬 Landing This PR is marked as "auto-merge" label Sep 11, 2024
@oskirby oskirby merged commit f9a83f5 into main Sep 11, 2024
113 of 114 checks passed
@oskirby oskirby deleted the taskcluster-remove-flatpaks branch September 11, 2024 18:00
jcristau added a commit to jcristau/mozilla-vpn-client that referenced this pull request Oct 8, 2024
jcristau added a commit that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛬 Landing This PR is marked as "auto-merge"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants