-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Taskcluster: remove flatpak build and toolchain tasks #9860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskirby
force-pushed
the
taskcluster-remove-flatpaks
branch
from
September 11, 2024 15:12
0c416cc
to
b9a05dd
Compare
oskirby
requested review from
jcristau,
mcleinman and
strseb
and removed request for
a team
September 11, 2024 15:59
jcristau
approved these changes
Sep 11, 2024
mcleinman
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫗 Pour one out for the podman worker.
strseb
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫡
jcristau
added a commit
to jcristau/mozilla-vpn-client
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the last update to flatpaks, we revised the build jobs in Github Workflows to make better use of the official Flatpak build tooling, and eliminated the need to manually vendor the rust crates by making use of the flatpak-cargo-generator.py script.
Once 2.24 is released, my plan is to attempt to create an official release on Flathub by migrating all of that work into the flathub organization so that they can begin generating and publishing official builds for us.
As such, we no longer really have a need to perform our own Flatpak builds using taskcluster as the release pipeline for the VPN on Flathub isn't going to touch any Mozilla infrastructure at all. Therefore, I think it is time that we remove the taskcluster flatpak build and toolchains tasks.
It is not without a little bit of sadness too, because I thought the
podman-worker.py
was a really neat piece of work to grant privileges to Docker containers that otherwise wouldn't have been possible via the Docker workers.Reference
Checklist