This repository has been archived by the owner on Mar 28, 2019. It is now read-only.
Fix basic auth ofuscation and prefix (fixes #128) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
128_basic_auth_prefix
branch
from
62fe7fb
to
f117a36
Compare
| self.request.registry.settings['cliquet.basic_auth_enabled'] = True | ||
|
|
||
| def test_prefixes_users_with_basicauth(self): | ||
| user_id = self.policy.unauthenticated_userid(self.request) |
There was a problem hiding this comment.
what about authenticated_userid?
There was a problem hiding this comment.
you mean the attribute on the request ?
It is set elsewhere in pyramid I guess....
|
ok looks good to me. |
| *args, | ||
| **kwargs) | ||
|
|
||
| def unauthenticated_userid(self, request): |
There was a problem hiding this comment.
unauthenticated_userid should be called only when we've went trough the authentication procedure already, and it's supposed to returned a cached version of the user id.
almet
added a commit
that referenced
this pull request
Mar 24, 2015
Fix basic auth ofuscation and prefix (fixes #128)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.