This repository has been archived by the owner on Mar 28, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Fix distinction and optimize (un)authenticated_userid #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
changed the title
Fix distinction and optimize (un)authenticated_userid
Fix distinction and optimize (un)authenticated_userid
Feb 3, 2016
@@ -77,6 +77,7 @@ | |||
'storage_url': '', | |||
'storage_max_fetch_size': 10000, | |||
'storage_pool_size': 25, | |||
'tm.annotate_user': False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean?
leplatrem
force-pushed
the
do-not-recompute-userid-hash
branch
from
February 10, 2016 12:08
ef8fec6
to
e359b3a
Compare
Now relies on Pyramid multiauth last version that triggers a policy selected event when effective_principals() is called and provides a user_id attribute on triggered event.
leplatrem
force-pushed
the
do-not-recompute-userid-hash
branch
from
February 11, 2016 13:51
e359b3a
to
2aee44c
Compare
@almet final r? :) |
""" | ||
# If pyramid_multiauth is used, a ``authn_type`` is set on request | ||
# when a policy succesfully authenticates a user. | ||
# (see :func:`cliquet.initializatio.setup_authentication`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: typo.
LGTM, good job! |
leplatrem
added a commit
that referenced
this pull request
Feb 15, 2016
…-hash Fix distinction and optimize (un)authenticated_userid
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyramid_tm
annotation of the transaction with unnecessary user info.pair=@almet