Skip to content
This repository has been archived by the owner on Mar 28, 2019. It is now read-only.

Fix distinction and optimize (un)authenticated_userid #641

Merged
merged 2 commits into from
Feb 15, 2016

Conversation

leplatrem
Copy link
Contributor

  • Disable pyramid_tm annotation of the transaction with unnecessary user info.
  • Fix distinction between unauthenticated_userid (cached) and authenticated_userid (verified) (?)
  • Make sure we don't compute user id hash several times per request
  • Requires Always trigger event and provide userid pyramid_multiauth#14 to be merged and released

pair=@almet

@leplatrem leplatrem changed the title Fix distinction and optimize (un)authenticated_userid Fix distinction and optimize (un)authenticated_userid Feb 3, 2016
@@ -77,6 +77,7 @@
'storage_url': '',
'storage_max_fetch_size': 10000,
'storage_pool_size': 25,
'tm.annotate_user': False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean?

Now relies on Pyramid multiauth last version that triggers
a policy selected event when effective_principals() is called
and provides a user_id attribute on triggered event.
@leplatrem
Copy link
Contributor Author

@almet final r? :)

"""
# If pyramid_multiauth is used, a ``authn_type`` is set on request
# when a policy succesfully authenticates a user.
# (see :func:`cliquet.initializatio.setup_authentication`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo.

@almet
Copy link
Contributor

almet commented Feb 11, 2016

LGTM, good job!

leplatrem added a commit that referenced this pull request Feb 15, 2016
…-hash

Fix distinction and optimize (un)authenticated_userid
@leplatrem leplatrem merged commit 9325c75 into master Feb 15, 2016
@leplatrem leplatrem deleted the do-not-recompute-userid-hash branch February 15, 2016 23:14
@leplatrem leplatrem modified the milestone: 3.0.0 Feb 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants