This repository has been archived by the owner on Mar 28, 2019. It is now read-only.
Fix PG behaviour when specifying timestamps in the past #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It had a different behaviour than other backends.
leplatrem
force-pushed
the
fix-behaviour-specified-timestamps
branch
from
54195d5
to
01157f8
Compare
|
I don't understand why you had to modify the 008_to_009 migration file. However it looks good to me. |
In PR #604, we updated the SQL schema, but didn't bump its version. As a consequence, the migration 008-009 was never executed. In PR #649, I replaced the orphan migration file 008-009 with a new one about collection timestamps (my fault). This PR restores the migration of #604 on 008-009 and puts the one of #649 into a new one 009-010. |
|
Ok makes sense 👍 |
| ``last_modified`` attribute. | ||
|
|
||
| The specified value will be ignored if it is less than the current collection | ||
| timestamp. |
There was a problem hiding this comment.
Incorrect statement.
|
r+ |
Natim
added a commit
that referenced
this pull request
Feb 26, 2016
…-timestamps Fix PG behaviour when specifying timestamps in the past
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote cleanly 4 four tests for storage backends:
I fixed the migrations of PR #604
And I updated the migration of PR #649 to fix the behaviour of PG for collection timestamps when specified record timestamp were in the past.