Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Do not return 500 error when filling cache #336

Closed
data-sync-user opened this issue Dec 10, 2021 · 0 comments · Fixed by #337
Closed

Do not return 500 error when filling cache #336

data-sync-user opened this issue Dec 10, 2021 · 0 comments · Fixed by #337
Assignees
@jrconlin

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Dec 10, 2021 •
edited
Loading

When we're rolling out a new deploy, the caches need to be filled. This can result in a spike of 500 errors to the client, which can cause a mild panic attack with Ops.

We should consider options to either return a softer error type (206?), an empty result, trigger a lag so that values are eventually filled and returned, or some other kinder behavior.

┆Issue is synchronized with this Jira Task
┆epic: Contile production v1
jrconlin added a commit that referenced this issue Dec 14, 2021
@jrconlin
feat: Make the partner timeouts "softer" during initial cache loading.
2397506 
Closes #336
@jrconlin jrconlin mentioned this issue Dec 14, 2021
Merged
jrconlin added a commit that referenced this issue Jan 11, 2022
@jrconlin
feat: Make the partner timeouts "softer" during initial cache loading. (
99cacad 
#337)

NOTE:
this changes the behavior of the `CONTILE_TEST_MODE` flag to be one of
several states:

**TestFakeResponse** = return a fake response from the ADM server
(previous "true")
**TestTimeout** = "timeout" a request to the ADM server.

Closes #336
@Trinaa Trinaa mentioned this issue Jun 21, 2023
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Make the partner timeouts "softer" during initial cache loading. mozilla-services/contile
2 participants
@jrconlin @data-sync-user