This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
test: replace contract test sequence diagram with Miro version #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trinaa
force-pushed
the
contract-test-sequence-diagram
branch
from
July 25, 2022 21:19
5df9ef3
to
42bb64d
Compare
pjenvey
previously approved these changes
Jul 25, 2022
hackebrot
suggested changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Trinaa! 👋🏻
We have added new fields to the cache audience key since I created the original. Do you mind updating that information?
See
Lines 22 to 35 in bd52656
pub struct AudienceKey { | |
/// Country in ISO 3166-1 alpha-2 format | |
pub country_code: String, | |
/// Region/subdivision (e.g. a US state) in ISO 3166-2 format | |
pub region_code: Option<String>, | |
/// The DMA code (u16) | |
pub dma_code: Option<u16>, | |
/// The form-factor (e.g. desktop, phone) of the device | |
pub form_factor: FormFactor, | |
/// Platform OS | |
pub os_family: OsFamily, | |
/// Only serve legacy | |
pub legacy_only: bool, | |
} |
pjenvey
previously approved these changes
Jul 26, 2022
Hi @hackebrot,
|
hackebrot
suggested changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Trinaa! 👋🏻
This is looking much better! Thank you.
Two minor corrections:
- The note on the left reads
verify the responses from contile
. Now that the diagram also shows an request fromclient
topartner
, should this beverify the responses from contile or partner
? - The description for a
204
HTTP response status isNo Content
. See https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/204
hackebrot
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✏️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update sequence diagram in contract-tests README to Miro version.
Issue(s)
CONSVC-1896