Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1930948 - Switch to more recent cli lib #401

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Bug 1930948 - Switch to more recent cli lib #401

merged 1 commit into from
Dec 2, 2024

Conversation

willdurand
Copy link
Member

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.33%. Comparing base (1700f53) to head (09dc8aa).

Files with missing lines Patch % Lines
main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   58.61%   58.33%   -0.28%     
==========================================
  Files           5        5              
  Lines         418      420       +2     
==========================================
  Hits          245      245              
- Misses        155      157       +2     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willdurand willdurand requested a review from jcristau November 13, 2024 14:50
@willdurand
Copy link
Member Author

That's a lot of code for a cli lib...

@willdurand
Copy link
Member Author

I'm not entirely happy about this PR but I'd rather keep up with the dep updates than do nothing. That said, I think - in the future - we might want to get rid of this dependency entirely.

@willdurand willdurand merged commit 956793d into master Dec 2, 2024
2 checks passed
@willdurand willdurand deleted the cli branch December 2, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants