This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(cache): Respect the max_removed_entry configuration #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
approved these changes
Dec 29, 2021
docs/ops.md
Outdated
| @@ -264,7 +264,7 @@ use. | |||
| a matching request is processed. | |||
| - `max_removed_entries` - While running the cleanup task, at most this many | |||
| entries will be removed before cancelling the task. This should be used to | |||
| limit the maximum amount of time the cleanup task takes. | |||
| limit the maximum amount of time the cleanup task takes. Defaults to 100000. | |||
There was a problem hiding this comment.
nit: consider using the same rust formatting (e.g. 100_000) for reading ease.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #285.