Merge pull request #4218 from chenba/4217-overlay-way-off

Calculate left and top margin of selection frame with left and top of doucument element and body
mozilla-services · Mar 13, 2018 · 0b9ce08 · 0b9ce08
2 parents 2ee7af6 + cd36b7c
commit 0b9ce08
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/addon/webextension/selector/ui.js b/addon/webextension/selector/ui.js
@@ -217,8 +217,8 @@ this.ui = (function() { // eslint-disable-line no-unused-vars
         if (window.getComputedStyle(document.body).position === "relative") {
           const docBoundingRect = document.documentElement.getBoundingClientRect();
           const bodyBoundingRect = document.body.getBoundingClientRect();
-          this.element.style.marginLeft = `-${bodyBoundingRect.right - docBoundingRect.right}px`;
-          this.element.style.marginTop = `-${bodyBoundingRect.bottom - docBoundingRect.bottom}px`;
+          this.element.style.marginLeft = `-${bodyBoundingRect.left - docBoundingRect.left}px`;
+          this.element.style.marginTop = `-${bodyBoundingRect.top - docBoundingRect.top}px`;
         }
       }
       if (force && visible) {