Do not uglify when NO_UGLIFY is set. (#4271) (#4272)

mozilla-services · Mar 27, 2018 · bb339f4 · bb339f4
1 parent 8630e74
commit bb339f4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.env.dev b/.env.dev
@@ -15,5 +15,6 @@ ENABLE_ANNOTATIONS=true
 SCREENSHOTS_UPLOAD_BINARY=true
 
 export NODE_ICU_DATA="$(pwd)/node_modules/full-icu"
+# For false, unset or set to empty string
 export NO_UGLIFY=true
 export NODE_ENV=dev
diff --git a/bin/build-scripts/bundle_dependencies b/bin/build-scripts/bundle_dependencies
@@ -43,13 +43,12 @@ build() {
   echo -n "bundle... "
   NODE_ENV="${NODE_ENV:-production}" browserify \
     -g [ envify --NODE_ENV $NODE_ENV ] \
-    $( [[ -z $NO_UGLIFY ]] && printf %s '-g uglifyify' ) \
-    -e "$@" \
-    | uglifyjs --compress --mangle > "$dest"
+    $( [[ -z "$NO_UGLIFY" ]] && printf %s '-g uglifyify' ) \
+    -e "$@" > "$dest"
 
   if [[ -z "$NO_UGLIFY" ]] ; then
     echo -n "minimizing... "
-    uglifyjs -c -o "$dest" "$dest"
+    uglifyjs --compress --mangle -o "$dest" "$dest"
   fi
   echo "done."
 }