Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Do not uglify when NO_UGLIFY is set. #4272

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Do not uglify when NO_UGLIFY is set. #4272

merged 1 commit into from
Mar 27, 2018

Conversation

chenba
Copy link
Collaborator

@chenba chenba commented Mar 26, 2018

Fixes #4271

jaredhirsch
jaredhirsch previously requested changes Mar 26, 2018
View reviewed changes
Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, shotindex-bundle.js is still uglified if I do NO_UGLIFY=true ./bin/run-server. Am I missing something? I verified that HTTP caching is disabled when I have devtools open.

@chenba
Copy link
Collaborator Author

chenba commented Mar 26, 2018

NO_UGLIFY need be exported as an environment variable in this case. (Or you can keep it as a shell var and call bundle_dependencies directly.)

@chenba chenba dismissed jaredhirsch’s stale review March 27, 2018 13:11

It should work when NO_UGLIFY is an environment variable.

jaredhirsch
jaredhirsch approved these changes Mar 27, 2018
View reviewed changes
Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Worked once I exported NO_UGLIFY=true and did make clean.

@jaredhirsch jaredhirsch merged commit bb339f4 into mozilla-services:master Mar 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaredhirsch jaredhirsch jaredhirsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenba @jaredhirsch