Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Investigate "filenameTitle is undefined" #2998

Closed
ianb opened this issue Jun 8, 2017 · 0 comments
Closed

Investigate "filenameTitle is undefined" #2998

ianb opened this issue Jun 8, 2017 · 0 comments
Assignees
Labels
✿sentry✿ Something related to an error report in our Sentry error collector
Milestone

Comments

@ianb
Copy link
Contributor

ianb commented Jun 8, 2017

In this Sentry report:

get filename@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/build/shot.js:349:5
exports.downloadShot/<@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/shooter.js:157:7
promise callback*exports.downloadShot@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/shooter.js:156:26
download@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/uicontrol.js:132:7
display/this.download.onclick<@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/ui.js:396:11
assertIsTrusted/<@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/assertIsTrusted.js:17:12
watchFunction/this.catcher@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/catcher.js:52:16
EventHandlerNonNull*display@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/ui.js:394:33
mouseup@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/uicontrol.js:650:7
addHandlers/</fn<@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/uicontrol.js:867:18
watchFunction/this.catcher@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/catcher.js:52:16
watchFunction/this.catcher@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/catcher.js:52:16
EventListener.handleEvent*installHandlersOnDocument@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/uicontrol.js:883:7
display/this.ui</this.element.onload<@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/ui.js:103:13
watchFunction/this.catcher@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/catcher.js:52:16
EventHandlerNonNull*display/this.ui<@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/ui.js:95:33
display@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/ui.js:81:14
display@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/ui.js:323:14
start@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/uicontrol.js:374:20
setState@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/uicontrol.js:192:7
exports.activate@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/uicontrol.js:821:7
this.uicontrol<@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/uicontrol.js:924:3
@moz-extension://769a0721-7d97-4131-a1c1-5e0c0d93be00/selector/uicontrol.js:6:19

Maybe caused by a page that has no identifiable title of any sort? That should default to the URL in some fashion.

@ianb ianb added the ✿sentry✿ Something related to an error report in our Sentry error collector label Jun 8, 2017
@ghost ghost modified the milestone: Stretch Jun 8, 2017
@ianb ianb self-assigned this Jun 8, 2017
ianb added a commit that referenced this issue Jun 8, 2017
Generally default to Screenshot for the title, for cases (like file urls) where even self.url is blank
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✿sentry✿ Something related to an error report in our Sentry error collector
Projects
None yet
Development

No branches or pull requests

1 participant