Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Firefox Screenshots is not compatible with Windows High Contrast themes #3174

Closed
emilghittasv opened this issue Jul 21, 2017 · 2 comments
Closed

Firefox Screenshots is not compatible with Windows High Contrast themes #3174

emilghittasv opened this issue Jul 21, 2017 · 2 comments
Assignees
@jaredhirsch
Labels
firefox Something that has to ship in the add-on in Firefox P2
Milestone
General Release 57

Comments

@emilghittasv
Copy link
Collaborator

[Affected versions]:
Firefox 55.0b11
Firefox Screenshots version: 10.5.0

Firefox 56.0a1
Firefox Screenshots version: 10.7.0

[Steps to reproduce]:

  1. Launch Firefox with a clean profile.
  2. Enable Firefox Screenshots.
  3. Enable a High Contrast Theme on Windows.

[Expected result]:
The Overlay is visible and screenshots can be easily performed.

[Actual result]:
The overlay is displayed as black (which makes the content not visible).

high contrast theme
@emilghittasv emilghittasv changed the title Firefox Screenshots are not compatible with Windows High Contrast themes Firefox Screenshots is not compatible with Windows High Contrast themes Jul 21, 2017
@johngruen johngruen added P3 P2 and removed P3 labels Aug 17, 2017
@ianb
Copy link
Contributor

ianb commented Aug 17, 2017

Maybe we can detect this and change styles: http://hanshillen.github.io/HCMDS/hcmode_detection.html

@johngruen
Copy link
Contributor

I wanna look at this on windows.

@johngruen johngruen self-assigned this Aug 17, 2017
@ghost ghost added the firefox Something that has to ship in the add-on in Firefox label Sep 21, 2017
@ghost ghost assigned jaredhirsch and unassigned johngruen Sep 22, 2017
@ianb ianb closed this as completed in c46d7dd Sep 27, 2017
ianb added a commit that referenced this issue Sep 27, 2017
@ianb
Merge pull request #3546 from mozilla-services/3174-hc-a11y
f56bda5 
Fix #3174, make selector view usable on high contrast themes
jaredhirsch added a commit that referenced this issue Sep 28, 2017
@jaredhirsch
Fix #3174, make selector view usable on high contrast themes
eae5061
jaredhirsch added a commit that referenced this issue Oct 2, 2017
@jaredhirsch
Revert "Fix #3174, make selector view usable on high contrast themes"
e354366 
This reverts commit c46d7dd.
jaredhirsch added a commit that referenced this issue Oct 2, 2017
@jaredhirsch
Use JS to detect and apply high contrast mode styles
7b572de 
Fixes #3174 and fixes #3565.
jaredhirsch added a commit that referenced this issue Oct 3, 2017
@jaredhirsch
Use JS to detect and apply high contrast mode styles
8bcf729 
Fixes #3174 and fixes #3565.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaredhirsch jaredhirsch

Labels
firefox Something that has to ship in the add-on in Firefox P2
Projects
None yet
Milestone
General Release 57
Development

No branches or pull requests
4 participants
@ianb @jaredhirsch @johngruen @emilghittasv