You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
We've switched to a pageAction for Firefox 57 / Photon. But we kept browserAction support so we could support older Firefox version. After discussion we realized we won't be deploying the current master to any versions of Firefox older than 57, so we can just remove the browserAction entirely.
This should remove the browserAction from manifest.json, and related code from bootstrap.js. We should probably get a review on this change from Mossop or kmag (if #3463 is done we could experiment with it for this).
The text was updated successfully, but these errors were encountered:
Seems like we should get this in before the 57 merge (on the 20th/21st, so just over a week away), or beta ends up with https://bugzilla.mozilla.org/show_bug.cgi?id=1396438 . Is "stretch" the appropriate milestone for this? @ianb ?
During testing I'm seeing this error in the Browser Console, during the selection process: TypeError: window is null WebNavigationFrames.jsm:59:1 – but these changes don't seem to affect the error one way or the other, so at least it's probably unrelated to this change.
This changes the add-on to require the Photon page action, with no fallback to a browserAction
- Removes test for Photon (assumes it is present)
- Removes bootstrap.js code that deletes the browserAction button
- Removes webextension code references to browserAction
- Removes Photon conditionals (i.e., assume it's always Photon)
- Make 57a1 the minimum version for the webextension/install.rdf
We've switched to a pageAction for Firefox 57 / Photon. But we kept browserAction support so we could support older Firefox version. After discussion we realized we won't be deploying the current master to any versions of Firefox older than 57, so we can just remove the browserAction entirely.
This should remove the browserAction from manifest.json, and related code from bootstrap.js. We should probably get a review on this change from Mossop or kmag (if #3463 is done we could experiment with it for this).
The text was updated successfully, but these errors were encountered: