Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Can't save screenshot from page with very long domain name #3530

Closed
zelitomas opened this issue Sep 21, 2017 · 2 comments
Closed

Can't save screenshot from page with very long domain name #3530

zelitomas opened this issue Sep 21, 2017 · 2 comments
Milestone
Stretch

Comments

@zelitomas
Copy link
Contributor

Server throws 500 error when trying to upload screenshot from URL with a long (but valid!) domain name - for example http://thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.thisisverylongdomainname.zelitomas.cf/
@zelitomas zelitomas mentioned this issue Sep 21, 2017
Closed
@ghost ghost added this to the Stretch milestone Sep 21, 2017
@testeaxeax
Copy link
Contributor

@wresuolc Currently the domain's length is restricted to 103 characters. What would be a appropriate max domain length?

@ghost
Copy link

ghost commented Nov 6, 2017

If the max is 253, then accepting that seems fine.

testeaxeax pushed a commit to testeaxeax/screenshots that referenced this issue Nov 7, 2017
Fix mozilla-services#3530, support domains up to 253 characters long
b12582b
@testeaxeax testeaxeax mentioned this issue Nov 7, 2017
Merged
@ianb ianb closed this as completed in #3733 Nov 8, 2017
ianb added a commit that referenced this issue Nov 8, 2017
@ianb
Merge pull request #3733 from testeaxeax/bug-3530
7408d09 
Fix #3530, support domains up to 253 characters long
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Stretch
Development

No branches or pull requests
2 participants
@zelitomas @testeaxeax