Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Selection Rectangle Shifted to the Left Upon Clicking on Element #3907

Closed
chenba opened this issue Dec 8, 2017 · 12 comments
Closed

Selection Rectangle Shifted to the Left Upon Clicking on Element #3907

chenba opened this issue Dec 8, 2017 · 12 comments
Assignees
Labels
defect firefox Something that has to ship in the add-on in Firefox

Comments

@chenba
Copy link
Collaborator

chenba commented Dec 8, 2017

STR

  1. Ensure your browser window is wide
  2. Go to npr.org
  3. Start Screenshots
  4. Click on one of the stories to select it

Expected

Element correctly selected and highlighted

Actual

image

@ghost
Copy link

ghost commented Dec 18, 2017

possible dupe if we can find the other issue

@ghost ghost added this to the Sprint 4 (59-3) 😯 milestone Dec 18, 2017
@johngruen johngruen added firefox Something that has to ship in the add-on in Firefox and removed firefox Something that has to ship in the add-on in Firefox labels Dec 20, 2017
@chenba chenba self-assigned this Jan 5, 2018
@Softvision-CristinaBadescu

I've managed to find a similar behavior on https://brightside.me. When you automatically perform a selection you can observe that it is shifted a little bit lower than the preview selection. This issue is reproducible on Firefox Screenshots v28.0.0.0, installed from here, on latest Nightly build 59.0a1 2018-01-05, on Windows 10x64, Mac 10.13 and Arch Linux 4.12.

Here is a screen recording with the issue:
wrong selection

@chenba
Copy link
Collaborator Author

chenba commented Jan 5, 2018

@Softvision-CristinaBadescu I cannot reproduce it on https://brightside.me. I did notice that you have something open at the bottom of your browser (some sort of counter?). Could you close that and try it again?

@Softvision-CristinaBadescu

Sure thing @chenba. I've closed Developer Toolbar, retested and still managed to reproduce it again. Moreover, I've managed to reproduce this on latest Firefox release 57.0.4 using Firefox Screenshots 19.2.0.
Here is the screen recording:
shifted selection rectangle

@chenba
Copy link
Collaborator Author

chenba commented Jan 5, 2018

@Softvision-CristinaBadescu the reason I wasn't able to reproduce it is that I had uBlock Origin running in that profile. :D

@chenba
Copy link
Collaborator Author

chenba commented Jan 5, 2018

This bug doesn't exist on Firefox 57.0.4 (Screenshots 19.2.0).

@chenba
Copy link
Collaborator Author

chenba commented Jan 5, 2018

The fix for #3256 is the source of this bug. (Note: Firefox Send has updated its CSS since #3256 was originally reported.)

@chenba
Copy link
Collaborator Author

chenba commented Jan 5, 2018

Note on testing with npr.org: ensure your document width is greater than 1300px.

@Softvision-CristinaBadescu

Hello @chenba! Hmmm, this is strange. I've tested this issue using Firefox Screenshots 19.2.0 on latest Firefox Release 57.0.4 and managed to reproduce it on Windows 10 x64, Mac 10.12.6 and Arch Linux 4.12.
Here is a screen recording with it:
shifted selection firefox release

@chenba
Copy link
Collaborator Author

chenba commented Jan 8, 2018

@Softvision-CristinaBadescu I am sorry, I should've been more specific. The shift on x (npr.org) did not exist on the older version of Screenshots, but the shift on y (brightside.me) did.

@Softvision-CristinaBadescu
Copy link

Softvision-CristinaBadescu commented Jan 15, 2018

This issue is no longer reproducible on https://www.npr.org/ using Firefox Screenshots v28.0.0 (installed from here) on Windows 10 x64, Mac 10.12.6 and Arch Linux 4.12.

As for https://brightside.me/, at first look everything seems ok, but I've managed to reproduce this issue by following these steps:

  1. Perform an automatically selection.
  2. Click "Cancel" button.
  3. Scroll down and perform another automatically selection.

Also, if you don't select "Cancel" button and scroll the page, this issue is not reproducible.
Moreover, this issue is not reproducible if you don't scroll the page after you clicked the "Close" button and perform another selection.

Here is a screen recording with this issue:
screenshots - shifted selection rectangle

@Softvision-CristinaBadescu

This issue is no longer reproducible using Firefox Screenshots 28.0.0 installed from here, on latest Nightly build 59.0a1 (2018-01-16), on Windows 10 x64, Mac 10.12.6 and Arch Linux 4.12.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect firefox Something that has to ship in the add-on in Firefox
Projects
None yet
Development

No branches or pull requests

4 participants