Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Unexpected attributes should not be errors in shot.js in prod #3959

Closed
ianb opened this issue Jan 10, 2018 · 0 comments
Closed

Unexpected attributes should not be errors in shot.js in prod #3959

ianb opened this issue Jan 10, 2018 · 0 comments
Assignees
@chenba
Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product
Milestone
Sprint 6 (60-1) 👨🏼‍🚀

Comments

@ianb
Copy link
Contributor

ianb commented Jan 10, 2018

The errors maybe kind of make sense in testing (though they haven't caught any errors for me in a very long time). Instead attributes should be warned about but ignored.
@ianb ianb added code Code quality issue, that does not have any outward effect on the product code quality Not a bug, targeted for fixing in 2018 labels Jan 10, 2018
@ghost ghost added this to the Sprint 6 (60-1) 👨🏼‍🚀 milestone Jan 24, 2018
@chenba chenba self-assigned this Jan 30, 2018
chenba added a commit to chenba/screenshots that referenced this issue Jan 30, 2018
@chenba
Do not throw error on unexpected attr in prod. (mozilla-services#3959)
99cf446
@chenba chenba mentioned this issue Jan 30, 2018
Merged
chenba added a commit to chenba/screenshots that referenced this issue Jan 30, 2018
@chenba
Do not throw error on unexpected attr in prod. (mozilla-services#3959)
2575e38
@ianb ianb closed this as completed in #4040 Feb 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chenba chenba

Labels
code quality Not a bug, targeted for fixing in 2018 code Code quality issue, that does not have any outward effect on the product
Projects
None yet
Milestone
Sprint 6 (60-1) 👨🏼‍🚀
Development

No branches or pull requests
2 participants
@ianb @chenba