Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Allow editing the shot title #573

Closed
ianb opened this issue Jul 15, 2015 · 2 comments
Closed

Allow editing the shot title #573

ianb opened this issue Jul 15, 2015 · 2 comments
Assignees
Milestone

Comments

@ianb
Copy link
Contributor

ianb commented Jul 15, 2015

Per #441 I find I want to edit the shot title so I can talk about what I am sharing, not what the page was intended to say.

@ianb ianb mentioned this issue Jul 15, 2015
@fzzzy fzzzy self-assigned this Jul 15, 2015
@fzzzy fzzzy added this to the First Launch milestone Jul 17, 2015
@fzzzy
Copy link
Contributor

fzzzy commented Jul 21, 2015

Bram, can you figure out what the interaction design for this will be like?

@ianb ianb assigned brampitoyo and unassigned fzzzy Jul 21, 2015
@ianb ianb modified the milestones: Next Tasks, First Launch Jul 28, 2015
@brampitoyo brampitoyo removed their assignment Sep 24, 2015
@ianb ianb modified the milestones: Next Tasks, Betelgeuse Oct 20, 2016
@ianb ianb self-assigned this Oct 28, 2016
@ianb
Copy link
Contributor Author

ianb commented Nov 1, 2016

Work is in cc10632

Interaction looks like this:

If you are the owner you hover, get a pointer cursor (not a text select cursor) and a pencil appears:

image

Click on it and you get editing:

image

You can hit Enter to accept, Escape to cancel. If you blur without editing the title, it goes back to normal. If you edit the title and blur then the input stays open.

If you erase the title entirely it is reset to the document (or opengraph) title. So if you edit the title, save, then edit and erase everything, you get the original.

When you save a .saving class is added to the title until the save completes.

@fzzzy fzzzy closed this as completed in cc10632 Nov 1, 2016
fzzzy added a commit that referenced this issue Nov 1, 2016
r?fzzzy Fix #573, make the shot title editable
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants