Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

extended direct-view event with ownership #2786

Merged
merged 1 commit into from
May 2, 2017
Merged

extended direct-view event with ownership #2786

merged 1 commit into from
May 2, 2017

Conversation

dannycoates
Copy link
Contributor

closes #2143

Copy link
Contributor

@ianb ianb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs an update to METRICS.md as well. In that document it should also note that CDNs will greatly deflate this measurement.

@dannycoates
Copy link
Contributor Author

Are we planning on using a CDN for screenshots? I was under the impression that we'll only be using one for site assets.

@ianb
Copy link
Contributor

ianb commented May 2, 2017

Yes, we were planning on using a CDN (under a separate domain name) for individual images, not just site assets.

@ianb ianb merged commit 64adacc into master May 2, 2017
@ianb ianb deleted the 2143-direct-owner branch May 2, 2017 18:42
@dannycoates
Copy link
Contributor Author

we were planning on using a CDN (under a separate domain name) for individual images

I think there's more work for this that doesn't have tracking issues like invalidating the CDN cache when the conditions used in the query for getRawBytesForClip change (block, delete, expire).

Secondarily, do we have evidence that CDNifying the screenshots will be worth the expense? My uneducated guess is that most shots aren't generally accessed by a large distribution of users. Maybe a simple http cache (nginx, varnish) would be enough. I guess I'm saying I don't understand the expectations / requirements.

cc #2210

@ianb
Copy link
Contributor

ianb commented May 2, 2017

You're right, there are important implications to the CDN. @relud did some calculations that using a CDN wouldn't be any more expensive than serving the images directly, even if the images weren't accessed in any volume.

@dannycoates
Copy link
Contributor Author

There's also the complexity cost. I'm not against it if it makes sense, I just want to understand the cost / benefits.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement event label to distinguish between owner and non-owner direct-views
2 participants