Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Update locales v10.10.0 #3293

Merged
merged 5 commits into from
Aug 9, 2017
Merged

Update locales v10.10.0 #3293

merged 5 commits into from
Aug 9, 2017

Conversation

flodolo
Copy link
Collaborator

@flodolo flodolo commented Aug 9, 2017

This takes localization from master and update the v10.10.0 branch

Discussion happening over email.

@johngruen
Copy link
Contributor

@flodolo commented in that email, but the failures caused by commit 6863352 make this branch significantly more risky. I'd recommend resubmitting w/o that commit, and then handling that separately.

@flodolo
Copy link
Collaborator Author

flodolo commented Aug 9, 2017

@flodolo commented in that email, but the failures caused by commit 6863352 make this branch significantly more risky. I'd recommend resubmitting w/o that commit, and then handling that separately.

I've checked, there are no commits passing tests on the v10.10.0 branch since Jul 20
https://github.com/mozilla-services/screenshots/commits/v10.10.0

Last commit has exactly the same type of failure
https://circleci.com/gh/mozilla-services/screenshots/2618?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

While the diff on this patch is big, it only touches localized FTL files (and doesn't touch en-US), so I don't see how it can make tests fail.

@ianb
Copy link
Contributor

ianb commented Aug 9, 2017

Tests have been failing because we removed the Full Page functionality, which was used by the tests. So yes, the failure is expected/OK

@ianb ianb merged commit b4355cb into mozilla-services:v10.10.0 Aug 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants