This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Upload jpeg #3513
Merged
Upload jpeg #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows JPEGs on the server, both to pass content checks, and to make use of stored content-types (instead of assuming image/png). - Puts an clip.image.type into shot objects - Uses .jpg for filenames when appropriate - Adds a new buildSetting for controlling the cutoff when we use JPEG - If a PNG image is too large, tries to make a JPEG and substitutes if the JPEG is actually smaller - Refactor some data:-URL and blob converstion functions into their own module
jaredhirsch
approved these changes
Sep 19, 2017
|
@ianb looks like a couple minor issues with the linter. I'll file a followup to fix em |
This was referenced Sep 19, 2017
Closed
ianb
added a commit
that referenced
this pull request
Sep 22, 2017
The clip object is used to inform the download filename, so we need to add a clip before generating the filename
jaredhirsch
pushed a commit
that referenced
this pull request
Sep 22, 2017
The clip object is used to inform the download filename, so we need to add a clip before generating the filename
ianb
added a commit
that referenced
this pull request
Sep 25, 2017
* Start #220, allow JPEG uploads, and respect content-type for JPEG or PNG * Fix #220, use JPEG for large shots - Allows JPEGs on the server, both to pass content checks, and to make use of stored content-types (instead of assuming image/png). - Puts an clip.image.type into shot objects - Uses .jpg for filenames when appropriate - Adds a new buildSetting for controlling the cutoff when we use JPEG - If a PNG image is too large, tries to make a JPEG and substitutes if the JPEG is actually smaller - Refactor some data:-URL and blob converstion functions into their own module
ianb
added a commit
that referenced
this pull request
Sep 25, 2017
The clip object is used to inform the download filename, so we need to add a clip before generating the filename
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-types (instead of assuming image/png).