Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Show expiration info on all screen sizes. Fixes: #5068 #5119

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

yehudab
Copy link
Contributor

@yehudab yehudab commented Oct 31, 2018

Fixes #5068

The fix includes showing full expiration info on all sizes but small.
For small, the time-diff part is removed.

Example:
screenshot_2018-10-31 firefox privacy notice

@jaredhirsch
Copy link
Member

@youwenliang What do you think: does it make sense to just show expiration, but not creation date, at the smallest widths?

@youwenliang
Copy link
Contributor

Looks good to me, I agree that expiration is more important than creation date.

Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@jaredhirsch jaredhirsch merged commit 299b5e7 into mozilla-services:master Nov 8, 2018
@yehudab yehudab deleted the show-expire-info branch November 9, 2018 05:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expiration info should always be visible
3 participants