Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Fix #5254 and fix #5253, remove FxA marketing #5272

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Fix #5254 and fix #5253, remove FxA marketing #5272

merged 1 commit into from
Jan 7, 2019

Conversation

ianb
Copy link
Contributor

@ianb ianb commented Jan 2, 2019

This simply says to never show the promotions (but does not remove the promotion code).

@ianb
Fix #5254 and fix #5253, remove FxA marketing
e1233a8 
This simply says to never show the promotions (but does not remove the promotion code).
@ianb ianb requested a review from jaredhirsch January 3, 2019 18:59
jaredhirsch
jaredhirsch suggested changes Jan 3, 2019
View reviewed changes
Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting out big chunks of code makes me sad. How about just deleting the code, or, if you're feeling fancy, create a NoPromotionStrategy subclass and load that into the widgets instead of this default Strategy?

@ianb
Copy link
Contributor Author

ianb commented Jan 4, 2019

I thought about deleting code, but it's all different kinds of pointless. I've been optimizing for size-of-diff.

@jaredhirsch
Copy link
Member

Fair enough

@jaredhirsch jaredhirsch merged commit daec240 into master Jan 7, 2019
@jaredhirsch jaredhirsch deleted the remove-marketing branch January 7, 2019 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaredhirsch jaredhirsch jaredhirsch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianb @jaredhirsch