Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reviewer group for list changes. #612

Merged
merged 2 commits into from
May 14, 2024
Merged

Add reviewer group for list changes. #612

merged 2 commits into from
May 14, 2024

Conversation

Trikolon
Copy link
Contributor

This allows us to automatically request review on new PRs from anti-tracking group members.

@Trikolon Trikolon requested a review from artines1 May 14, 2024 10:26
artines1
artines1 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@artines1 artines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good automation, thanks.

@artines1 artines1 merged commit e899c7d into master May 14, 2024
1 of 2 checks passed
@Trikolon Trikolon deleted the review-group branch May 14, 2024 12:42
@martinthomson
Copy link

@artines1 @Trikolon I think we have a bug:

Unknown owner on line 1: make sure the team @mozilla/shavar_reviewers exists, is publicly visible, and has write access to the repository

  • @mozilla/shavar_reviewers

Is that group under @mozilla-services instead, perhaps?

@Trikolon
Copy link
Contributor Author

@artines1 @Trikolon I think we have a bug:

Unknown owner on line 1: make sure the team @mozilla/shavar_reviewers exists, is publicly visible, and has write access to the repository

  • @mozilla/shavar_reviewers

Is that group under @mozilla-services instead, perhaps?

Yes. Fix is in #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artines1 artines1 artines1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trikolon @martinthomson @artines1