Show Flow errors in yarn test
(as a Jest reporter)
#6617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a custom Jest reporter that shows Flow errors in our test output.
In practical usage, I don't think there will be any impact to speed. There might be a couple seconds of delay when the server starts for the first time but that happens in parallel to the tests anyway.
This fixes mozilla/addons#12498 by removing the need to run
yarn flow:dev
. It even implements part of mozilla/addons#10342 🍰I've actually wanted to see Flow errors in test output for a while but for some reason it never struck me to create a reporter! It also seems like a decent workaround to jestjs/jest#7124
Some examples:
Flow failures
No Flow errors