Update config to run addons-frontend with addons-server locally #9956
Conversation
Codecov Report
@@ Coverage Diff @@
## master mozilla/addons-server#9956 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 262 262
Lines 7609 7609
Branches 1374 1374
=======================================
Hits 7487 7487
Misses 114 114
Partials 8 8 Continue to review full report at Codecov.
|
willdurand
changed the title
willdurand
force-pushed
the
yarn-amo-olympia
branch
from
4ec8b1b
to
d150c65
Compare
There was a problem hiding this comment.
Thanks for taking care of this @willdurand! It seems to be working for me. I'm getting an error on the search API, but I believe that's related to my local addons-server install and not this. I am able to view an add-on detail page using data from the local add-on server with this patch, so I believe it's working. I had one question about the port, but otherwise r+wc.
| @@ -37,10 +37,9 @@ Here are some commands you can run: | |||
|
|
|||
| | Command | Description | | |||
| | --- | --- | | |||
| | yarn amo | Start the dev server/proxy (for amo) using data from Docker. _This is not currently working. See [issue-7196][]_. | | |||
| | yarn amo:olympia | Start the dev server/proxy (for amo) using data from a local addons-server environment. | | |||
There was a problem hiding this comment.
Do you think it's worth adding a note that the site will be located at http://olympia.test:4000? I know that is output to the console, so maybe not necessary, but it could be helpful for folks expecting it to be the same location as with amo:dev and amo:stage.
There was a problem hiding this comment.
Hmm, is it http://olympia.test:4000 or http://olympia.test:3333? Both seem to work.
There was a problem hiding this comment.
:3333 is the app, which runs behind the proxy at :4000.
There was a problem hiding this comment.
I think the output is fine. We don't develop with both local envs in parallel usually so I think it's for power users who would read the console output :)
Fixes mozilla/addons#12793
Fixes mozilla/addons#6520