Update dependency eslint to v7 #3163
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/eslint-7.x
branch
2 times, most recently
from
a29bbf1 to
c37eede
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/eslint-7.x
branch
from
c37eede to
975258f
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/eslint-7.x
branch
from
975258f to
27580f7
Compare
renovate
bot
changed the title
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/eslint-7.x
branch
4 times, most recently
from
54348d0 to
fd5b51a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3163 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 57 57
Lines 1981 1981
Branches 414 414
=======================================
Hits 1979 1979
Misses 2 2
Continue to review full report at Codecov.
|
willdurand
force-pushed
the
renovate/eslint-7.x
branch
from
fd5b51a to
ba5026c
Compare
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. If you think this comment is in error and the branch is not modified, try deleting this comment. If it comes back again the next time Renovate runs, please submit an issue or seek config help. |
willdurand
force-pushed
the
renovate/eslint-7.x
branch
from
d04378c to
25ae9c3
Compare
| }); | ||
|
|
||
| // eslint-disable-next-line jest/no-disabled-tests | ||
| it.skip('should support public class fields', async () => { |
There was a problem hiding this comment.
I think this isnt supported yet but we should start adding some test cases for various syntaxes for the future
There was a problem hiding this comment.
apparently (even if Firefox seems to support them from version 69 and Chrome from version 72) public class instance fields are still stage 3: https://github.com/tc39/proposal-class-fields
and unfortunately I was unable to find an existing issue in the eslint repository that does track it (I did find one closed about the private fields, but none about the public instance fields)
we may just reference https://github.com/tc39/proposal-class-fields here to more quickly double-check when the README in that repo will be changed to stage 4.
There was a problem hiding this comment.
This lgtm! follows some review comments (just nits on the test side)
Thanks @willdurand!
| }); | ||
|
|
||
| // eslint-disable-next-line jest/no-disabled-tests | ||
| it.skip('should support public class fields', async () => { |
There was a problem hiding this comment.
apparently (even if Firefox seems to support them from version 69 and Chrome from version 72) public class instance fields are still stage 3: https://github.com/tc39/proposal-class-fields
and unfortunately I was unable to find an existing issue in the eslint repository that does track it (I did find one closed about the private fields, but none about the public instance fields)
we may just reference https://github.com/tc39/proposal-class-fields here to more quickly double-check when the README in that repo will be changed to stage 4.
willdurand
force-pushed
the
renovate/eslint-7.x
branch
from
960eae7 to
479f043
Compare
Co-authored-by: William Durand <will+git@drnd.me>
Fixes #3085
Fixes #3169
Fixes #2498