Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use library mode for kotlin docs #6391

Open
wants to merge 1 commit into from
Open

Conversation

gruberb
Copy link
Member

@gruberb gruberb commented Sep 23, 2024

Using the uniffi-bindgen library mode to generate components. We updated suggest and relevancy and removed the UDL file. Therefore, both components are missing in the current published docs.

@gruberb gruberb force-pushed the fix-kotlin-docs branch 2 times, most recently from 70cdde4 to b5a692d Compare September 23, 2024 12:39
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.72%. Comparing base (ed20db0) to head (2f10950).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6391       +/-   ##
===========================================
+ Coverage   27.05%   52.72%   +25.66%     
===========================================
  Files         264      125      -139     
  Lines       24981    12820    -12161     
===========================================
  Hits         6759     6759               
+ Misses      18222     6061    -12161     
Flag Coverage Δ
52.72% <ø> (+25.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gruberb gruberb force-pushed the fix-kotlin-docs branch 5 times, most recently from 054dbf0 to 5d4f6d9 Compare September 23, 2024 14:41
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple minor comments.

@gruberb gruberb added this pull request to the merge queue Sep 23, 2024
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants