Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1936456 - Don't consider unvisited-but-bookmarked pages to be visited. #6527

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

linabutler
Copy link
Member

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

@linabutler linabutler requested a review from mhammond December 13, 2024 00:09
@linabutler linabutler marked this pull request as ready for review December 13, 2024 00:09
@linabutler linabutler force-pushed the 1936456-get-visited-match-desktop branch from c4d4e47 to 03febc3 Compare December 13, 2024 00:10
@linabutler linabutler force-pushed the 1936456-get-visited-match-desktop branch from 03febc3 to cce90b6 Compare December 13, 2024 07:35
Copy link
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@linabutler linabutler added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 1b9d2eb Dec 13, 2024
15 checks passed
@linabutler linabutler deleted the 1936456-get-visited-match-desktop branch December 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants