Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fido2 support #78

Merged
merged 8 commits into from
May 2, 2019
Merged

Conversation

baloo
Copy link

@baloo baloo commented Mar 17, 2019

This is still a work in progress, and I'm sharing early, but at some point we should be able to use ctap2 devices.

@baloo baloo force-pushed the baloo/wip/features/fido2 branch from 873a093 to 976a129 Compare March 18, 2019 00:56
@baloo baloo force-pushed the baloo/wip/features/fido2 branch 8 times, most recently from 0c207ba to 80cb811 Compare March 29, 2019 05:02
@baloo baloo changed the base branch from master to ctap2 March 29, 2019 05:04
Arthur Gautier added 2 commits March 29, 2019 05:05
Signed-off-by: Arthur Gautier <baloo@gandi.net>
Signed-off-by: Arthur Gautier <baloo@gandi.net>
@baloo baloo force-pushed the baloo/wip/features/fido2 branch 4 times, most recently from 938c948 to 19aa4dd Compare March 29, 2019 05:17
@baloo
Copy link
Author

baloo commented Mar 29, 2019

serde_bytes/serde_cbor errors could be related to pyfisch/cbor#102.

@baloo baloo force-pushed the baloo/wip/features/fido2 branch 2 times, most recently from 52a9661 to c0f90d8 Compare March 29, 2019 16:19
@jcjones jcjones added this to the CTAP2 / FIDO2 Support milestone Mar 29, 2019
@baloo baloo force-pushed the baloo/wip/features/fido2 branch 10 times, most recently from d007440 to 7719798 Compare April 1, 2019 19:21
Arthur Gautier added 4 commits April 1, 2019 19:27
Signed-off-by: Arthur Gautier <baloo@gandi.net>
Signed-off-by: Arthur Gautier <baloo@gandi.net>
Signed-off-by: Arthur Gautier <baloo@gandi.net>
Signed-off-by: Arthur Gautier <baloo@gandi.net>
@baloo baloo force-pushed the baloo/wip/features/fido2 branch 3 times, most recently from da14539 to 6702cf8 Compare April 3, 2019 23:47
Signed-off-by: Arthur Gautier <baloo@gandi.net>
@baloo baloo force-pushed the baloo/wip/features/fido2 branch from 6702cf8 to 101739f Compare April 4, 2019 21:20
@baloo baloo force-pushed the baloo/wip/features/fido2 branch 2 times, most recently from cc048df to 062607f Compare April 22, 2019 21:36
Signed-off-by: Arthur Gautier <baloo@gandi.net>
@baloo baloo force-pushed the baloo/wip/features/fido2 branch from 062607f to df28de2 Compare April 22, 2019 23:27
Copy link
Contributor

@jcjones jcjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is through the new code, in cose and ctap2. Submitting as a block, proceeding onto the rest of src

src/ctap.rs Show resolved Hide resolved
src/ctap.rs Show resolved Hide resolved
src/ctap2/attestation.rs Show resolved Hide resolved
src/ctap2/attestation.rs Show resolved Hide resolved
src/ctap2/attestation.rs Show resolved Hide resolved
src/ctap2/commands.rs Show resolved Hide resolved
src/ctap2/commands.rs Show resolved Hide resolved
src/ctap2/server.rs Show resolved Hide resolved
src/ctap2/server.rs Show resolved Hide resolved
src/ctap2/server.rs Show resolved Hide resolved
@jcjones
Copy link
Contributor

jcjones commented May 2, 2019

Merging this into unstable branch ctap2. Further comments will be opened as issues against that.

@jcjones jcjones merged commit 819dd7f into mozilla:ctap2 May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants