-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: fido2 support #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/wip/features/fido2
branch
from
March 18, 2019 00:56
873a093
to
976a129
Compare
baloo
force-pushed
the
baloo/wip/features/fido2
branch
8 times, most recently
from
March 29, 2019 05:02
0c207ba
to
80cb811
Compare
Signed-off-by: Arthur Gautier <baloo@gandi.net>
Signed-off-by: Arthur Gautier <baloo@gandi.net>
baloo
force-pushed
the
baloo/wip/features/fido2
branch
4 times, most recently
from
March 29, 2019 05:17
938c948
to
19aa4dd
Compare
serde_bytes/serde_cbor errors could be related to pyfisch/cbor#102. |
baloo
force-pushed
the
baloo/wip/features/fido2
branch
2 times, most recently
from
March 29, 2019 16:19
52a9661
to
c0f90d8
Compare
baloo
force-pushed
the
baloo/wip/features/fido2
branch
10 times, most recently
from
April 1, 2019 19:21
d007440
to
7719798
Compare
Signed-off-by: Arthur Gautier <baloo@gandi.net>
Signed-off-by: Arthur Gautier <baloo@gandi.net>
Signed-off-by: Arthur Gautier <baloo@gandi.net>
Signed-off-by: Arthur Gautier <baloo@gandi.net>
baloo
force-pushed
the
baloo/wip/features/fido2
branch
3 times, most recently
from
April 3, 2019 23:47
da14539
to
6702cf8
Compare
Signed-off-by: Arthur Gautier <baloo@gandi.net>
baloo
force-pushed
the
baloo/wip/features/fido2
branch
from
April 4, 2019 21:20
6702cf8
to
101739f
Compare
baloo
force-pushed
the
baloo/wip/features/fido2
branch
2 times, most recently
from
April 22, 2019 21:36
cc048df
to
062607f
Compare
Signed-off-by: Arthur Gautier <baloo@gandi.net>
baloo
force-pushed
the
baloo/wip/features/fido2
branch
from
April 22, 2019 23:27
062607f
to
df28de2
Compare
jcjones
reviewed
May 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review is through the new code, in cose
and ctap2
. Submitting as a block, proceeding onto the rest of src
This was referenced May 2, 2019
Merging this into unstable branch ctap2. Further comments will be opened as issues against that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress, and I'm sharing early, but at some point we should be able to use ctap2 devices.