-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch mobile_search_clients_daily
derived table to pull from baseline ping from Aug 01st 2024 onwards
#5985
Open
alekhyamoz
wants to merge
2
commits into
main
Choose a base branch
from
mobile_baseline_metrics_switch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration report for "Fix CI errors"
|
alekhyamoz
changed the title
Switch to
Switch Jul 30, 2024
mobile_search_clients_daily
to pull from metrics from Aug 01st 2024 onwardsmobile_search_clients_daily
derived table to pull from baseline ping from Aug 01st 2024 onwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent KPI DAU changes and the need to align the search DAU with KPI.
We will be changing the SQL to pull the search related metrics from
baseline
tables instead ofmetrics
.The planned cut-off is Aug 1st 2024.
As part of this effort, we need to -
Before Aug 1st 2024 (Implemented as part of - #5977)
**[Done]**create a v2 table to pull from the baseline table
[Done] monitor and validate v1 and v2 tables for ~1 week
on Aug 1st 2024 -
3. create a prehistory table
mobile_clients_daily_historical_pre202408
with all historical data frommetrics
table4. change the view and mobile_aggregates to pull from both history and v2
5. Change other downstream tables to pull from the new view
mobile_search_clients_daily
6. cut off populating v1
Checklist for reviewer:
<username>:<branch>
of the fork as parameter. The parameter will also show upin the logs of the
manual-trigger-required-for-fork
CI task together with more detailed instructions.For modifications to schemas in restricted namespaces (see
CODEOWNERS
):┆Issue is synchronized with this Jira Task