Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate BigConfig files for views #6312

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Generate BigConfig files for views #6312

merged 2 commits into from
Oct 10, 2024

Conversation

scholtzan
Copy link
Collaborator

@scholtzan scholtzan commented Oct 8, 2024

Description

The BigConfig files that should be applied for views are different from those applied to tables.
This PR handles the generation of these config files for views.

Reviewer, please follow this checklist

┆Issue is synchronized with this Jira Task

@dataops-ci-bot
Copy link

Integration report for "Re-enable monitoring for telemetry.releases"

sql.diff

Click to expand!
Only in /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases: bigconfig.yml
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases/bigconfig.yml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases/bigconfig.yml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases/bigconfig.yml	1970-01-01 00:00:00.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases/bigconfig.yml	2024-10-08 18:25:20.000000000 +0000
@@ -0,0 +1,21 @@
+type: BIGCONFIG_FILE
+row_creation_times:
+  column_selectors:
+  - name: moz-fx-data-shared-prod.moz-fx-data-shared-prod.telemetry.releases.date
+tag_deployments:
+- deployments:
+  - column_selectors:
+    - name: moz-fx-data-shared-prod.moz-fx-data-shared-prod.telemetry.releases.*
+    metrics:
+    - metric_type:
+        type: PREDEFINED
+        predefined_metric: FRESHNESS_DATA
+      metric_schedule:
+        named_schedule:
+          name: Default Schedule - 13:00 UTC
+    - metric_type:
+        type: PREDEFINED
+        predefined_metric: VOLUME_DATA
+      metric_schedule:
+        named_schedule:
+          name: Default Schedule - 13:00 UTC
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases/metadata.yaml	2024-10-08 18:23:24.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/telemetry/releases/metadata.yaml	2024-10-08 18:23:56.000000000 +0000
@@ -19,7 +19,7 @@
   view.sql:
   - moz-fx-data-shared-prod.telemetry_derived.releases_v1
 monitoring:
-  enabled: false
+  enabled: true
   collection: null
   partition_column: date
   partition_column_set: true

Link to full diff

@alekhyamoz alekhyamoz added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit c0114f4 Oct 10, 2024
21 checks passed
@alekhyamoz alekhyamoz deleted the bigconfig-for-views branch October 10, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants