-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create iOS_onboarding.toml #6316
Open
rhythmofrain63
wants to merge
3
commits into
main
Choose a base branch
from
rhythmofrain63-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added iOS_onboarding.toml - query for generating the underlying table in the iOS onboarding dashboard.
This comment has been minimized.
This comment has been minimized.
kik-kik
reviewed
Oct 10, 2024
kik-kik
reviewed
Oct 10, 2024
from_expression = """ | ||
firefox_ios.firefox_ios_clients ic --each client_id has only one row | ||
LEFT JOIN `moz-fx-data-shared-prod`.firefox_ios_derived.funnel_retention_clients_week_4_v1 r --each client_id has only one row | ||
ON ic.client_id = r.client_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you could also use the more concise USING(client_id)
here instead.
kik-kik
reviewed
Oct 10, 2024
This comment has been minimized.
This comment has been minimized.
Integration report for "feat: remove locale from dimension list, it does not exist in the source table"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added iOS_onboarding.toml - query for generating the underlying table in the iOS onboarding dashboard.
Description
Related Tickets & Documents
Reviewer, please follow this checklist
┆Issue is synchronized with this Jira Task